cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "punith s" <punit...@cloudbyte.com>
Subject Re: Review Request 25647: enabling the rootdisksize variable for vm creation wrt managed storage
Date Thu, 18 Sep 2014 05:41:13 GMT


> On Sept. 16, 2014, 12:14 p.m., punith s wrote:
> > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java,
line 200
> > <https://reviews.apache.org/r/25647/diff/1/?file=689316#file689316line200>
> >
> >     yes mike, when you create a compute offering with  a specified min and max iops
on contrary to the custom iops, iops was setting null for the root disk, since a new rootdiskoffering
object is being created, predefined iops were not being set.
> >     
> >     and yes, this issue is not related to this S3 bug, but i thought it to be a
minor one, so i clubbed it with this review.
> 
> Mike Tutkowski wrote:
>     That's interesting...none of my regression tests indicated that fixed-size IOPS (i.e.
non-custom IOPS) were not being set for root volumes. I actually create VMs using these kinds
of Compute Offerings regularly and my IOPS seem to be set properly on the SolidFire SAN.
>     
>     Have you actually observed this as an issue in practice or does the code as is simply
not look like it would work?
>     
>     Thanks for clarifying!

hi mike,

i have sent a new review request on this bug, also i have mentioned the scenario when this
was actually occuring.
https://reviews.apache.org/r/25732/

thanks.


- punith


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25647/#review53488
-----------------------------------------------------------


On Sept. 17, 2014, 5:52 p.m., punith s wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25647/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 5:52 p.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Bugs: 7406
>     https://issues.apache.org/jira/browse/7406
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> since cloudstack is not able to process the S3 or Switf templates for its virtual size(root
disk size), admin is facing issues while creating a vm using third party storage plugins like
cloudbyte and solidfire etc.
> this patch enables the resize of root disk, on passing a  variable ismanagedstorage =
true in deployVmCmd as a detail.
> hence template root disksize is overriden by the given rootdisk size by the admin
> 
> this patch also fixes the iops null issue.
> 
> for more ref
> https://issues.apache.org/jira/browse/CLOUDSTACK-7406
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 
> 
> Diff: https://reviews.apache.org/r/25647/diff/
> 
> 
> Testing
> -------
> 
> dry run only.
> 
> 
> Thanks,
> 
> punith s
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message