cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Tutkowski" <mike.tutkow...@solidfire.com>
Subject Re: Review Request 25647: enabling the rootdisksize variable for vm creation wrt managed storage
Date Tue, 16 Sep 2014 20:49:59 GMT


> On Sept. 16, 2014, 12:44 a.m., punith s wrote:
> > engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java,
line 200
> > <https://reviews.apache.org/r/25647/diff/1/?file=689316#file689316line200>
> >
> >     yes mike, when you create a compute offering with  a specified min and max iops
on contrary to the custom iops, iops was setting null for the root disk, since a new rootdiskoffering
object is being created, predefined iops were not being set.
> >     
> >     and yes, this issue is not related to this S3 bug, but i thought it to be a
minor one, so i clubbed it with this review.

That's interesting...none of my regression tests indicated that fixed-size IOPS (i.e. non-custom
IOPS) were not being set for root volumes. I actually create VMs using these kinds of Compute
Offerings regularly and my IOPS seem to be set properly on the SolidFire SAN.

Have you actually observed this as an issue in practice or does the code as is simply not
look like it would work?

Thanks for clarifying!


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25647/#review53488
-----------------------------------------------------------


On Sept. 16, 2014, 5:46 a.m., punith s wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25647/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2014, 5:46 a.m.)
> 
> 
> Review request for cloudstack and Mike Tutkowski.
> 
> 
> Bugs: 7406
>     https://issues.apache.org/jira/browse/7406
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> since cloudstack is not able to process the S3 or Switf templates for its virtual size(root
disk size), admin is facing issues while creating a vm using third party storage plugins like
cloudbyte and solidfire etc.
> this patch enables the resize of root disk, on passing a  variable ismanagedstorage =
true in deployVmCmd as a detail.
> hence template root disksize is overriden by the given rootdisk size by the admin
> 
> this patch also fixes the iops null issue.
> 
> for more ref
> https://issues.apache.org/jira/browse/CLOUDSTACK-7406
> 
> 
> Diffs
> -----
> 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
2b49954 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 
> 
> Diff: https://reviews.apache.org/r/25647/diff/
> 
> 
> Testing
> -------
> 
> dry run only.
> 
> 
> Thanks,
> 
> punith s
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message