cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 25637: CLOUDSTACK-7387: Corrected code related to adding host tags
Date Tue, 16 Sep 2014 06:08:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25637/
-----------------------------------------------------------

(Updated Sept. 16, 2014, 11:38 a.m.)


Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.


Changes
-------

This is updated patch. Earlier cleanup code did not remove the host tags, instead added the
same tags.
Please revert earlier patch, and commit this one.


Bugs: CLOUDSTACK-7387
    https://issues.apache.org/jira/browse/CLOUDSTACK-7387


Repository: cloudstack-git


Description
-------

The host tags were not defined and not added to hosts before.

Changes:
1) Searched for cluster with two hosts within the given zone.
2) Updated hosts with host tags and added same tags in service offerings used to created VM.
3) Deleted the host tags in cleanup.
4) Corrected the imports.


Diffs (updated)
-----

  test/integration/component/maint/test_vpc_host_maintenance.py 83ba271 

Diff: https://reviews.apache.org/r/25637/diff/


Testing
-------

Yes.

Ran setUpClass by skipping the test cases. Hosts updated successfully with tags and VMs were
deployed.

Log:
Test enable Maintenance Mode on Hosts which have VPC elements ... SKIP: skip
Test cancel Maintenance Mode on the above Hosts + Migrate VMs Back ... SKIP: skip
Test reconnect Host which has VPC elements ... SKIP: skip

----------------------------------------------------------------------
Ran 3 tests in 465.545s

OK (SKIP=3)


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message