cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Tutkowski" <mike.tutkow...@solidfire.com>
Subject Re: Review Request 25647: enabling the rootdisksize variable for vm creation wrt managed storage
Date Mon, 15 Sep 2014 18:21:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25647/#review53369
-----------------------------------------------------------



engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
<https://reviews.apache.org/r/25647/#comment92999>

    Were you seeing a problem when you ran your tests that indicated that this code should
be added?
    
    Is this code related to this review request or is it solving another problem you saw?
    
    Thanks!



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/25647/#comment93000>

    Perhaps you can fill me in a bit on how this works from an overall point of view.
    
    It looks like the user is creating a VM and we want this person to specify a virtual size
for the root disk (because we don't know the virtual size if the template is stored on S3
or Swift).
    
    Does the user now have to specific a virtual size even if the template is stored on NFS?
    
    How does the user know that he needs to (or doesn't need to) specifiy the virtual size
(i.e. if it's on NFS, you don't need to; if it's on S3 or Swift, you do need to)?


- Mike Tutkowski


On Sept. 15, 2014, 8:11 a.m., punith s wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25647/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 8:11 a.m.)
> 
> 
> Review request for cloudstack, amit kumar das and Mike Tutkowski.
> 
> 
> Bugs: 7406
>     https://issues.apache.org/jira/browse/7406
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> since cloudstack is not able to process the S3 or Switf templates for its virtual size(root
disk size), admin is facing issues while creating a vm using third party storage plugins like
cloudbyte and solidfire etc.
> this patch enables the resize of root disk, on passing a  variable ismanagedstorage =
true in deployVmCmd as a detail.
> hence template root disksize is overriden by the given rootdisk size by the admin
> 
> this patch also fixes the iops null issue.
> 
> for more ref
> https://issues.apache.org/jira/browse/CLOUDSTACK-7406
> 
> 
> Diffs
> -----
> 
>   engine/orchestration/src/org/apache/cloudstack/engine/orchestration/CloudOrchestrator.java
2b49954 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 0ea2a89 
> 
> Diff: https://reviews.apache.org/r/25647/diff/
> 
> 
> Testing
> -------
> 
> dry run only.
> 
> 
> Thanks,
> 
> punith s
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message