cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 25642: CLOUDSTACK-7547: Brocade Device Data was hard coded, moved it to config file
Date Mon, 15 Sep 2014 12:39:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25642/
-----------------------------------------------------------

(Updated Sept. 15, 2014, 6:09 p.m.)


Review request for cloudstack, Ritu  Sabharwal, Santhosh Edukulla, and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7547
    https://issues.apache.org/jira/browse/CLOUDSTACK-7547


Repository: cloudstack-git


Description (updated)
-------

Brocade device data was hard coded. 

1) Made changes so that it can be read from the config file. (Config tranlated to the config
file we provide to jenkins, not test_data.py file, because dynamic data should always be placed
in config, not test_data.py)
2) Skipped the test case if the data is not present in config file.
3) Removed * from imports and made appropriate changes.


Diffs
-----

  test/integration/component/test_brocade_vcs.py a5eff53 

Diff: https://reviews.apache.org/r/25642/diff/


Testing
-------

Yes.

Tested all the scenarios of valid and invalid data.
Skipping of test case was proper.

When all the data was present, test case moved forward to adding the brocade device but test
case still failed because the details I put in config file were not valid (I don't have brocade
device details).


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message