cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "SrikanteswaraRao Talluri" <srikanteswararao.tall...@citrix.com>
Subject Re: Review Request 25573: CLOUDSTACK-7135: test_baremetal.py - Tagging test case as invalid
Date Mon, 15 Sep 2014 11:22:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25573/#review53324
-----------------------------------------------------------

Ship it!


I feel removing 'basic' is sufficient to exclude from the filter while running tests. However,
adding 'invalid' doesn't harm, incase if we want to list all invalid cases.

- SrikanteswaraRao Talluri


On Sept. 12, 2014, 6:30 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25573/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2014, 6:30 a.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7135
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7135
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> The test case tries to create a guest network in basic zone, which is not possible on
daily run setups as the setup would have already a guest network present.
> 
> As confirmed by Frank Zhang, this test case should be skipped in daily runs as there
is no valid test case right now present for baremetal. The test case has never passed in any
of the past build.
> 
> Removing "basic" tag from test case and adding "invalid" tag. Removal of basic tag ensures
the test case is not picked up in runs. Adding of "invalid" tag tellls us this test case is
invalid.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_baremetal.py 6ab9146 
> 
> Diff: https://reviews.apache.org/r/25573/diff/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message