cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request 25476: CLOUDSTACK-7520: [UI] keep advanced search parameters visible after search has been run.
Date Wed, 10 Sep 2014 08:40:26 GMT


> On Sept. 9, 2014, 2:02 p.m., Rohit Yadav wrote:
> > ui/scripts/ui/widgets/listView.js, line 1857
> > <https://reviews.apache.org/r/25476/diff/1/?file=683961#file683961line1857>
> >
> >     Should n't this be declared as var, also this is not used or referenced in the
function definition.
> 
> Mihaela Stoica wrote:
>     This is where the saved advanced search parameters are cleared when a basic search
is run.
>     The variable is declared in the scope of makeListView() function (ln 1934) and is
referenced in three places:
>     - populated after the advanced search is run (ln 1960)
>     - read when the advanced search box is invocked (ln 1949)
>     - cleared when a basic search is run (ln 1857)

Thanks, LGTM.


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25476/#review52718
-----------------------------------------------------------


On Sept. 9, 2014, 1:47 p.m., Mihaela Stoica wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25476/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 1:47 p.m.)
> 
> 
> Review request for cloudstack, Brian Federle and Jessica Wang.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> - Preserve the advanced search parameters, so that when the advanced search box is shown
again,
> it is populated with the values selected/entered previously, unless they have navigated
away from the search results page,
> or applied any additional filters/search parameters.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/ui/widgets/listView.js 22182c1 
> 
> Diff: https://reviews.apache.org/r/25476/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mihaela Stoica
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message