cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devdeep Singh" <devdeep.si...@citrix.com>
Subject Re: Review Request 25426: CLOUDSTACK-7370: Fixed password visible in plain text if password passed is in the end in url
Date Wed, 10 Sep 2014 06:27:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25426/#review52827
-----------------------------------------------------------


Change looks ok but Utils unit test is failing. Kindly address the issue with failed unit
tests too.

- Devdeep Singh


On Sept. 8, 2014, 8:22 a.m., Anshul Gangwar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25426/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 8:22 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Devdeep Singh.
> 
> 
> Bugs: CLOUDSTACK-7370
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7370
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> updated the regular expression which is used to clean password
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/StringUtils.java 17b8fc0 
> 
> Diff: https://reviews.apache.org/r/25426/diff/
> 
> 
> Testing
> -------
> 
> tested by passing affected strings through regular expressions.
> 
> 
> Thanks,
> 
> Anshul Gangwar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message