cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request 25435: [CLOUDSTACK-7159] Add "usageid" parameter to the "listUsageRecords" API call.
Date Tue, 09 Sep 2014 13:55:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25435/#review52715
-----------------------------------------------------------

Ship it!


Ship It!

- Rohit Yadav


On Sept. 9, 2014, 1:44 p.m., Ilia Shakitko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25435/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 1:44 p.m.)
> 
> 
> Review request for cloudstack, Alena Prokharchyk, Kishan Kavala, and Sheng Yang.
> 
> 
> Bugs: CLOUDSTACK-7159
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7159
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Working with Usage server and usage records very often I need to get only records for
that particular usage ID. For example when filtering out network_bytes_received/sent with
big amount of data it's not very fast to process hundreds of objects looking for the only
one you need.
> It would be useful to have an ability to filter out usage records only for specific resource
ID.
> 
> This parch brings that to the API.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 6baa95c 
>   api/src/org/apache/cloudstack/api/command/admin/usage/GetUsageRecordsCmd.java 21a7e4a

>   server/src/com/cloud/usage/UsageServiceImpl.java d1f62aa 
> 
> Diff: https://reviews.apache.org/r/25435/diff/
> 
> 
> Testing
> -------
> 
> Tested cases:
> - usageid is specified w/o "type": an exception is thrown (correct)
> - provided usageid is not exists: an empty response is returned (since no records were
found, correct)
> - no usageid specified: work as is
> - an existing usageid specified (with type, for example type=4 or type=5): only records
for that usage type is returned
> 
> 
> Thanks,
> 
> Ilia Shakitko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message