cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Re: Review Request 25433: CLOUDSTACK-7509: Added missing bound method in base library for copyTemplate operation
Date Tue, 09 Sep 2014 06:25:01 GMT


> On Sept. 9, 2014, 11:48 a.m., SrikanteswaraRao Talluri wrote:
> > It would be nice if you could submit patches which replaces other occurences copytemplate
code in test_templates.py
> > 
> > cmd = copyTemplate.copyTemplateCmd()
> >         cmd.id = self.template_2.id
> >         cmd.destzoneid = self.services["destzoneid"]
> >         cmd.sourcezoneid = self.services["sourcezoneid"]
> >         self.apiclient.copyTemplate(cmd)

Sure, I will submit patch for it.


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25433/#review52681
-----------------------------------------------------------


On Sept. 8, 2014, 6:07 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25433/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 6:07 p.m.)
> 
> 
> Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-7509
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7509
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Bound method for copyTemplate was missing in library, hence test cases failed during
copy operation.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/lib/base.py 982986b 
> 
> Diff: https://reviews.apache.org/r/25433/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> Test copy template between zones ... === TestName: test_04_copy_template_1_root_domain_admin
| Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 427.374s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message