cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Review Request 25431: CLOUDSTACK-7506: Fix base library to read hypevisor value from dictionary as opposed to only from function parameter
Date Mon, 08 Sep 2014 11:35:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25431/
-----------------------------------------------------------

Review request for cloudstack, sanjeev n, Santhosh Edukulla, and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-7506
    https://issues.apache.org/jira/browse/CLOUDSTACK-7506


Repository: cloudstack-git


Description
-------

Few test cases in Secondary Storage Limits failed due to error in registering Template - "Invalid
Parameters - hypervisor is required".

Base library function is reading hypervisor value only from function parameter and not from
services dictionary. But the test cases are passing hypervisor value from dictionary.

Solution:
Read the hypervisor value from the services dict if it's not passed through the function parameter.


Diffs
-----

  tools/marvin/marvin/lib/base.py 982986b 

Diff: https://reviews.apache.org/r/25431/diff/


Testing
-------

Yes.

Test Try to deploy VM with admin account where account has not used ... === TestName: test_01_deploy_vm_domain_limit_reached
| Status : SUCCESS ===
ok
Test Try to deploy VM with admin account where account has used ... SKIP: skip
Test TTry to deploy VM with admin account where account has not used ... SKIP: skip

----------------------------------------------------------------------
Ran 3 tests in 199.895s

OK (SKIP=2)


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message