cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chandan Purushothama" <Chandan.Purushoth...@citrix.com>
Subject Re: Review Request 25187: test_delete_account and test_releaseIP failing in advanced zone
Date Thu, 04 Sep 2014 20:26:33 GMT


> On Sept. 4, 2014, 8:24 p.m., Chandan Purushothama wrote:
> > Ship It!

I reviewed the patch. I read the entire test suite to understand the Use Cases. The Suite
does refer to the wrong dictionary "nat_rule" instead of "lb_rule". Alex's patch should fix
the issue.


- Chandan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25187/#review52348
-----------------------------------------------------------


On Sept. 3, 2014, 3:17 p.m., Alex Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25187/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 3:17 p.m.)
> 
> 
> Review request for cloudstack, Ashutosh Kelkar, Santhosh Edukulla, and SrikanteswaraRao
Talluri.
> 
> 
> Bugs: CLOUDSTACK-7448
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7448
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-4840 changed test_data.py to make the lbrule publicport be 22,
> instead of 2222. In doing so, this caused the following tests to fail, as they
> hit a problem where they tried to use port 22 for both the lbrule and for other
> purposes:
> integration.smoke.test_network.TestDeleteAccount.test_delete_account
> integration.smoke.test_network.TestReleaseIP.test_releaseIP
> 
> The reason the change appears to have been made was that in
> test_lb_secondary_ip.py, despite setting up the load balancer using lbrule, the
> tests then used the SSH port from natrule to try and access the VM. By changing
> lbrule to use port 22 (the same as natrule) this avoided the problem.
> 
> This patch updates test_lb_secondary_ip.py to use the SSH port in lbrule where
> necessary to access the VMs, and reverts the change to test_data.py
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_lb_secondary_ip.py f54caa6 
>   tools/marvin/marvin/config/test_data.py fca2442 
> 
> Diff: https://reviews.apache.org/r/25187/diff/
> 
> 
> Testing
> -------
> 
> Ran tests in test_lb_secondary_ip.py with changes in place, verified results equivalent
to those seen on regular regression runs.
> Ran test_delete_account and test_releaseIP to verify these now pass as expected.
> 
> 
> Thanks,
> 
> Alex Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message