cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "daan Hoogland" <daan.hoogl...@gmail.com>
Subject Re: Review Request 24794: Review request for CLOUDSTACK-6169 - assignVirtualMachine leaves associated tags assigned to old account
Date Thu, 04 Sep 2014 09:43:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24794/#review52290
-----------------------------------------------------------


What testing has been done?
Can you ad a unit test for the functions that contain the new code?

- daan Hoogland


On Aug. 18, 2014, 9:54 a.m., Namita Chaudhari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24794/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2014, 9:54 a.m.)
> 
> 
> Review request for cloudstack and Marcus Sorensen.
> 
> 
> Bugs: CLOUDSTACK-6169 and https://issues.apache.org/jira/browse/CLOUDSTACK-6169
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6169
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6169
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6169 - assignVirtualMachine leaves associated tags assigned to old account
> 
> When a VM is assigned from one account to another, the tags associated to the VM points
to the new account and not old one.
> 
> 
> Diffs
> -----
> 
>   engine/schema/src/com/cloud/tags/ResourceTagVO.java eadddd1 
>   engine/schema/src/com/cloud/tags/dao/ResourceTagDao.java fffe2a47 
>   engine/schema/src/com/cloud/tags/dao/ResourceTagsDaoImpl.java 3611999 
>   server/src/com/cloud/vm/UserVmManagerImpl.java e5de11f 
> 
> Diff: https://reviews.apache.org/r/24794/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Namita Chaudhari
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message