cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Brett" <alex.br...@citrix.com>
Subject Re: Review Request 24882: CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are not applicable for hyper-v
Date Wed, 03 Sep 2014 23:54:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24882/#review52262
-----------------------------------------------------------



test/integration/component/test_escalations_ipaddresses.py
<https://reviews.apache.org/r/24882/#comment91028>

    Is there a reason for making this change - getHypervisorInfo is generally what is used
elsewhere rather than the hypervisor property of services?
    
    (getHypervisorInfo has the benefit that if we ever need to start testing mixed clouds
we can make sure it returns the type we want this particular test to run on, rather than the
single value in services)



test/integration/component/test_escalations_isos.py
<https://reviews.apache.org/r/24882/#comment91030>

    I don't see anything from cloudstackException or SshClient being used in this file - any
reason to add imports for them?



test/integration/component/test_escalations_isos.py
<https://reviews.apache.org/r/24882/#comment91027>

    Other things in the file use PASS from marvin.codes so this should still be imported.



test/integration/component/test_escalations_isos.py
<https://reviews.apache.org/r/24882/#comment91026>

    This will break unless you change the existing usages of time.sleep to just sleep (personally
I'd leave it as import time though).



test/integration/component/test_escalations_isos.py
<https://reviews.apache.org/r/24882/#comment91031>

    Not your bug, but the wording here is poor - should probably be "Not enough zones exist
to copy iso" or similar.


- Alex Brett


On Aug. 20, 2014, 4:22 a.m., Vinay Varma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24882/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2014, 4:22 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-6282
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6282
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-6282 - Added skip condition when hypervisor is hyper-v for tests which are
not applicable for hyper-v
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_escalations_instances.py 1b72b2f 
>   test/integration/component/test_escalations_ipaddresses.py 6c9b24b 
>   test/integration/component/test_escalations_isos.py a0fa333 
>   test/integration/component/test_escalations_networks.py 56f61b4 
>   test/integration/component/test_escalations_snapshots.py af493a1 
>   test/integration/component/test_escalations_volumes.py d1dae12 
> 
> Diff: https://reviews.apache.org/r/24882/diff/
> 
> 
> Testing
> -------
> 
> Executed the tests and attached are the log files for each of the files changed.
> 
> 
> File Attachments
> ----------------
> 
> InstancesResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/4ac84a27-fc7c-4b8c-9509-d75a350b53a3__InstancesResults.txt
> IPAddressesResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/14aad713-9256-44ed-a9e2-d7225c5c975c__IPAddressesResults.txt
> IsoResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/516de1c8-09d0-4e07-abe4-3483463750c3__IsoResults.txt
> SnapshotsResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/46f2a6c3-f0f7-4397-918e-bb8df1d63e97__SnapshotsResults.txt
> VolumeResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/28d59100-315b-45e8-9aaa-b60982571637__VolumeResults.txt
> NetworksResults.txt
>   https://reviews.apache.org/media/uploaded/files/2014/08/20/869b26e2-9fc2-44cf-bbc1-fc13fd60bc58__NetworksResults.txt
> 
> 
> Thanks,
> 
> Vinay Varma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message