Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (nike.apache.org: domain of runseb@gmail.com designates
 74.125.82.45 as permitted sender)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
Subject: Re: cloud-init issue
From: Sebastien Goasguen <runseb@gmail.com>
In-Reply-To: <53FB2B90.8050903@widodh.nl>
Date: Mon, 25 Aug 2014 08:28:59 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <F25DFF1A-FC08-4B6C-94AE-17A157F90D27@gmail.com>
References: <9FB72686-9762-4F52-AA4D-ACA7134FA533@gmail.com>
 <53FB1AF1.9000704@widodh.nl>
 <CAP997Uc4LAD8Sv43=HXQQx9c=vz7_c4OZ_L3JUAY2x8Q9DnO1A@mail.gmail.com>
 <CAP997UfWcg1a-E09AQJMQBGULQJvTgbjgrANte+fJQhHt5TUWw@mail.gmail.com>
 <737782029.79410.1408966424951.JavaMail.zimbra@li.nux.ro>
 <53FB291F.2030206@widodh.nl> <5E3F347D-84CA-4214-8E74-B0B3B5173B25@gmail.com>
 <53FB2B90.8050903@widodh.nl>
To: dev@cloudstack.apache.org


On Aug 25, 2014, at 8:26 AM, Wido den Hollander <wido@widodh.nl> wrote:

> On 08/25/2014 02:25 PM, Sebastien Goasguen wrote:
>>=20
>> On Aug 25, 2014, at 8:16 AM, Wido den Hollander <wido@widodh.nl> =
wrote:
>>=20
>>> On 08/25/2014 01:33 PM, Nux! wrote:
>>>> Thanks Erik!
>>>>=20
>>>=20
>>> Indeed!
>>>=20
>>>> Hopefully this change will be incorporated soon so we don't need to =
patch cloud-init.
>>>>=20
>>>=20
>>> I came up with a very small patch: =
https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;a=3Dcommitdiff;=
h=3D1499972804b6de4fade5c84436e29f9904165e18
>>>=20
>>> Tested it on my local env and worked fine. Both the old and new URL =
work with the same output.
>>>=20
>>=20
>> thanks folks, I will pull that in 4.3
>>=20
>=20
> Hmm. I didn't make a separate branch as a hotfix for 4.4, so how do we =
get this in 4.4.1 as well?
>=20
> We shouldn't cherry-pick anymore, right?

Ideally no, if you make a hotfix/4.4-7405 branch for it you can ask Daan =
to merge it in 4.4 branch

I will also merge it in 4.3


>=20
> Wido
>=20
>>=20
>>=20
>>> Wido
>>>=20
>>>>=20
>>>>=20
>>>> --
>>>> Sent from the Delta quadrant using Borg technology!
>>>>=20
>>>> Nux!
>>>> www.nux.ro
>>>>=20
>>>>=20
>>>> ----- Original Message -----
>>>>> From: "Erik Weber" <terbolous@gmail.com>
>>>>> To: "dev" <dev@cloudstack.apache.org>
>>>>> Sent: Monday, 25 August, 2014 12:34:10 PM
>>>>> Subject: Re: cloud-init issue
>>>>>=20
>>>>> On Mon, Aug 25, 2014 at 1:27 PM, Erik Weber <terbolous@gmail.com> =
wrote:
>>>>>=20
>>>>>> On Mon, Aug 25, 2014 at 1:16 PM, Wido den Hollander =
<wido@widodh.nl>
>>>>>> wrote:
>>>>>>=20
>>>>>>> On 08/25/2014 12:12 PM, Sebastien Goasguen wrote:
>>>>>>>=20
>>>>>>>> Folks,
>>>>>>>>=20
>>>>>>>> There is an outstanding issue with cloud-init compatibility.
>>>>>>>> The VR serves the instance metadata through a web server but =
there is a
>>>>>>>> trailing slash issue:
>>>>>>>>=20
>>>>>>>> https://issues.apache.org/jira/browse/CLOUDSTACK-7405
>>>>>>>>=20
>>>>>>>> Does anyone know where the settings for this web server are =
located in
>>>>>>>> the cloudstack code ?
>>>>>>>>=20
>>>>>>>>=20
>>>>>>> So I think that is done in systemvm/patches/debian/
>>>>>>> config/opt/cloud/bin/vmdata.py
>>>>>>>=20
>>>>>>> It adds a RewriteRule to the .htaccess like:
>>>>>>>=20
>>>>>>> entry =3D "RewriteRule ^meta-data/(.+)$  ../" + folder +
>>>>>>> "/%{REMOTE_ADDR}/$1 [L,NC,QSA]"
>>>>>>>=20
>>>>>>> I'm not a big mod_rewrite guru however.
>>>>>>>=20
>>>>>>>=20
>>>>>> Adding a line with "RewriteRule ^meta-data$ ../" + folder
>>>>>> +"/%{REMOTE_ADDR}/$1 [L,NC,QSA]"
>>>>>> should suffice.
>>>>>>=20
>>>>>> small typo there...
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>>=20
>>>>>> Tested on a VR with this config:
>>>>>>=20
>>>>>> RewriteRule ^meta-data/(.+)$  ../metadata/%{REMOTE_ADDR}/$1 =
[L,NC,QSA]
>>>>>>=20
>>>>>> RewriteRule ^meta-data/$  ../metadata/%{REMOTE_ADDR}/meta-data =
[L,NC,QSA]
>>>>>>=20
>>>>>> RewriteRule ^meta-data$  ../metadata/%{REMOTE_ADDR}/meta-data =
[L,NC,QSA]
>>>>>>=20
>>>>>>=20
>>>>>>=20
>>>>> A better solution is probably to make the last slash conditional, =
like this:
>>>>> RewriteRule ^meta-data/?$  ../metadata/%{REMOTE_ADDR}/meta-data =
[L,NC,QSA]
>>>>>=20
>>>>> tested:
>>>>> [root@jenkins ~]# curl -I -s 10.30.81.1/latest/meta-data/ | grep =
HTTP
>>>>>=20
>>>>> HTTP/1.1 200 OK
>>>>>=20
>>>>> [root@jenkins ~]# curl -I -s 10.30.81.1/latest/meta-data | grep =
HTTP
>>>>>=20
>>>>> HTTP/1.1 200 OK
>>>>>=20
>>>>> Erik
>>>>>=20
>>>=20
>>=20
>=20