Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: unknown (nike.apache.org: error in processing during lookup of
 pdion@cloudops.com)
MIME-Version: 1.0
In-Reply-To: 
 <CAGQtxvaWY2Qa6vgjm_sgcCLjdy5rY-y9wMac1oOgyVHsa=Cdfw@mail.gmail.com>
References: 
 <CAD97iocsFV_c3m93UFMerfycMz6bLhx70Q+jtywOkTr04YEeFA@mail.gmail.com>
	<CAGQtxvaWY2Qa6vgjm_sgcCLjdy5rY-y9wMac1oOgyVHsa=Cdfw@mail.gmail.com>
Date: Tue, 19 Aug 2014 11:14:55 -0400
Message-ID: 
 <CAD97iof782B_413Bj5bGEutP=r8avvyZDvsmLXvXyTQzLSRewg@mail.gmail.com>
Subject: Re: [acs441][acs450] hotfix merge request
From: Pierre-Luc Dion <pdion@cloudops.com>
To: "dev@cloudstack.apache.org" <dev@cloudstack.apache.org>
Content-Type: multipart/alternative; boundary=001a11c3bfaa3adfce0500fcf3f3

--001a11c3bfaa3adfce0500fcf3f3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Daan,
The one you are looking at is only removing end of line spaces.
the commit 29c12bb78c37bf8c7ae4c2fd6f528974fc44e707 is the real fix.  I've
tested it and it fixe the current 4.4.0 issue while using Swift as SS.   It
is a cut and paste of a previous commit of yours for S3.

Thanks!

Pierre-Luc


On Tue, Aug 19, 2014 at 10:37 AM, Daan Hoogland <daan.hoogland@gmail.com>
wrote:

> Pierre-Luc,
>
> What is this supposed to do? I see no change in the logic in your commit:
>
> commit 62d9843e0ce9e9c2418258697e583dd9de4a68d0
> Author: Pierre-Luc Dion <pdion891@apache.org>
> Date:   Thu Aug 14 13:07:32 2014 -0400
>
>     NfsSecondaryStorageResource.java:remove empty spaces
>
> diff --git
>
> a/services/secondary-storage/server/src/org/apache/cloudstack/storage/res=
ource/NfsSecondaryStorageResource.java
> b/services/secondary-storage/server/src/org/
> index f095403..f9a06f1 100755
> ---
>
> a/services/secondary-storage/server/src/org/apache/cloudstack/storage/res=
ource/NfsSecondaryStorageResource.java
> +++
>
> b/services/secondary-storage/server/src/org/apache/cloudstack/storage/res=
ource/NfsSecondaryStorageResource.java
> @@ -329,7 +329,7 @@ public class NfsSecondaryStorageResource extends
> ServerResourceBase implements S
>                      s_logger.error(errMsg);
>                      return new CopyCmdAnswer(errMsg);
>                  }
> -            }
> +            }
>
>              File destFile =3D SwiftUtil.getObject(swiftTO,
> downloadDirectory, srcData.getPath());
>              return postProcessing(destFile, downloadPath, destPath,
> srcData, destData);
>
>
> On Sat, Aug 16, 2014 at 4:55 PM, Pierre-Luc Dion <pdion@cloudops.com>
> wrote:
>
> > Hi,
> >
> > Please merge hotfix/4.4-7343  into 4.4 branch.  master branch is also
> > affected so potentially 4.5 so can this be merge into those branch as
> well
> > ?
> >
> > https://issues.apache.org/jira/browse/CLOUDSTACK-7343
> >
> >
> > It as been tested with 4.4.1 and seams to resolve unworkable swift as
> > secondary storage. This fix is a cut and past from S3 same behavior [1]=
.
> >
> >
> >
> > Thanks !
> >
> > [1]
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=3Dcloudstack.git;a=3Dblobdiff;f=
=3Dservices/secondary-storage/server/src/org/apache/cloudstack/storage/reso=
urce/NfsSecondaryStorageResource.java;h=3D78f4bf19a9192f1df581c1c0ddb90f249=
1a93cc9;hp=3D6927f028cf23db81c86c8e5d0059e3a3c3f37a81;hb=3D6b8b7b82f41c415f=
1e0d1ed715e14f3664e39e22;hpb=3Df7dd1720cb6217d4425e9a92268f6b716e88a18c
> >
> >
> >
> > *Pierre-Luc DION*
> > Architecte de Solution Cloud | Cloud Solutions Architect
> > t 855.652.5683
> >
> > *CloudOps* Votre partenaire infonuagique* | *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
>
>
>
> --
> Daan
>

--001a11c3bfaa3adfce0500fcf3f3--