Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Received-SPF: pass (athena.apache.org: domain of silvano@corp.globo.com
 designates 74.125.149.73 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1F3F4B7B-534D-400A-BED8-95EAF1E7DE8D@shapeblue.com>
References: <75A38343-2A53-4B98-8745-AE1E9F5AE5C2@shapeblue.com>
 <B93FD736-CEBD-4206-A789-7C1887644CF5@gmail.com>
 <E1656015-3013-469F-A573-5E7C1521A63F@shapeblue.com>
 <4CFC8347-8946-4F95-95A1-0450212BF221@gmail.com>
 <1F3F4B7B-534D-400A-BED8-95EAF1E7DE8D@shapeblue.com>
From: Silvano Nogueira Buback <silvano@corp.globo.com>
Date: Wed, 27 Aug 2014 06:29:01 -0300
Message-ID: 
 <CA+rXN786mApJ7y6JZQ58R5Oa7a=p2Ji9ahcPQ_Wh9_oCVBag+Q@mail.gmail.com>
Subject: Re: [MERGE] Merge saml2 branch to master
To: dev@cloudstack.apache.org
Content-Type: multipart/alternative; boundary=089e01183d4e20a7e50501990e07

--089e01183d4e20a7e50501990e07
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

I'm trying use your implementation to implement OAuth2. It's almost
working, but I think is necessary a little change:

Class APIAuthenticationManagerImpl is calling command without correct
spring context. I'm working in 4.3 branch, so, I will show what I changed:


   - org.apache.cloudstack.api.auth.PluggableAPIAuthenticator needs to
   implements PluggableService and have no more method getAuthCommands.
   - Little patch in APIAuthenticationManagerImpl

+++ b/server/src/com/cloud/api/auth/APIAuthenticationManagerImpl.java
@@ -55,24 +55,31 @@ public class APIAuthenticationManagerImpl extends
ManagerBase implements APIAuth
     @Override
     public boolean start() {
         s_authenticators =3D new HashMap<String, Class<?>>();
-        for (Class<?> authenticator: getCommands()) {
-            APICommand command =3D
authenticator.getAnnotation(APICommand.class);
-            if (command !=3D null && !command.name().isEmpty()
-                    &&
APIAuthenticator.class.isAssignableFrom(authenticator)) {
-                s_authenticators.put(command.name(), authenticator);
+        for (Class<?> authenticatorCommand: getCommands()) {
+            registerCommandsInAPIAuthenticator(authenticatorCommand);
+        }
+        // Register all external APIAuthenticator(s)
+        for (PluggableAPIAuthenticator apiAuthenticator:
_apiAuthenticators) {
+            for (Class<?> authenticatorCommand:
apiAuthenticator.getCommands()) {
+                registerCommandsInAPIAuthenticator(authenticatorCommand);
             }
         }
         return true;
     }

+    private void registerCommandsInAPIAuthenticator(Class<?>
authenticator) {
+        APICommand command =3D authenticator.getAnnotation(APICommand.clas=
s);
+        if (command !=3D null && !command.name().isEmpty()
+                && APIAuthenticator.class.isAssignableFrom(authenticator))
{
+            s_authenticators.put(command.name(), authenticator);
+        }
+    }
+
     @Override
     public List<Class<?>> getCommands() {
         List<Class<?>> cmdList =3D new ArrayList<Class<?>>();
         cmdList.add(DefaultLoginAPIAuthenticatorCmd.class);
         cmdList.add(DefaultLogoutAPIAuthenticatorCmd.class);
-        for (PluggableAPIAuthenticator apiAuthenticator:
_apiAuthenticators) {
-            cmdList.addAll(apiAuthenticator.getAuthCommands());
-        }
         return cmdList;
     }


Now, authentication commands work inside plugin context.
PluggableAPIAuthenticator needs to implement tradicional getCommands to
work.

Best regards,

Silvano Buback


On Tue, Aug 26, 2014 at 6:59 AM, Rohit Yadav <rohit.yadav@shapeblue.com>
wrote:

>
> On 26-Aug-2014, at 11:47 am, Sebastien Goasguen <runseb@gmail.com> wrote:
> > we do have some selenium tests in /test/selenium but I don't think they
> are being run.
> >
> > +1 from me (satisfied with your answers)
>
> Thanks! Few more classes;
>
> Class, %Method, %Line, %
> GetServiceProviderMetaDataCmd100% (1/ 1)62.5% (5/ 8)77.9% (53/ 68)
> SAMLMetaDataResponse100% (1/ 1)66.7% (2/ 3)80% (4/ 5)
>
> From IntelliJ: http://people.apache.org/~bhaisaab/samlcoverage.png
>
> Regards,
> Rohit Yadav
> Software Architect, ShapeBlue
> M. +41 779015219 | rohit.yadav@shapeblue.com
> Blog: bhaisaab.org | Twitter: @_bhaisaab
>
>
>
> Find out more about ShapeBlue and our range of CloudStack related service=
s
>
> IaaS Cloud Design & Build<
> http://shapeblue.com/iaas-cloud-design-and-build//>
> CSForge =E2=80=93 rapid IaaS deployment framework<http://shapeblue.com/cs=
forge/>
> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
> CloudStack Infrastructure Support<
> http://shapeblue.com/cloudstack-infrastructure-support/>
> CloudStack Bootcamp Training Courses<
> http://shapeblue.com/cloudstack-training/>
>
> This email and any attachments to it may be confidential and are intended
> solely for the use of the individual to whom it is addressed. Any views o=
r
> opinions expressed are solely those of the author and do not necessarily
> represent those of Shape Blue Ltd or related companies. If you are not th=
e
> intended recipient of this email, you must neither take any action based
> upon its contents, nor copy or show it to anyone. Please contact the send=
er
> if you believe you have received this email in error. Shape Blue Ltd is a
> company incorporated in England & Wales. ShapeBlue Services India LLP is =
a
> company incorporated in India and is operated under license from Shape Bl=
ue
> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Bras=
il
> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd i=
s
> a company registered by The Republic of South Africa and is traded under
> license from Shape Blue Ltd. ShapeBlue is a registered trademark.
>

--089e01183d4e20a7e50501990e07--