Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 525331092B for ; Fri, 8 Aug 2014 17:51:11 +0000 (UTC) Received: (qmail 8271 invoked by uid 500); 8 Aug 2014 17:51:10 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 8223 invoked by uid 500); 8 Aug 2014 17:51:10 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 8208 invoked by uid 99); 8 Aug 2014 17:51:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Aug 2014 17:51:10 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of rohit.yadav@shapeblue.com designates 213.199.154.20 as permitted sender) Received: from [213.199.154.20] (HELO emea01-am1-obe.outbound.protection.outlook.com) (213.199.154.20) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Aug 2014 17:51:05 +0000 Received: from DBXPR07MB480.eurprd07.prod.outlook.com (10.141.231.154) by DBXPR07MB477.eurprd07.prod.outlook.com (10.141.231.146) with Microsoft SMTP Server (TLS) id 15.0.1005.10; Fri, 8 Aug 2014 17:50:41 +0000 Received: from DBXPR07MB480.eurprd07.prod.outlook.com ([10.141.231.154]) by DBXPR07MB480.eurprd07.prod.outlook.com ([10.141.231.154]) with mapi id 15.00.0995.014; Fri, 8 Aug 2014 17:50:42 +0000 From: Rohit Yadav To: dev CC: "shadowsor@gmail.com" Subject: [DISCUSS] Removing template URL format checking logic Thread-Topic: [DISCUSS] Removing template URL format checking logic Thread-Index: AQHPszFFF2R/dn4bgEupbl/zNGTS+w== Date: Fri, 8 Aug 2014 17:50:41 +0000 Message-ID: <98F851FC-E116-4ED4-BB73-1B94DC9E4338@shapeblue.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [178.199.146.103] x-microsoft-antispam: BCL:0;PCL:0;RULEID:;UriScan:; x-forefront-prvs: 02973C87BC x-forefront-antispam-report: SFV:NSPM;SFS:(6009001)(13734003)(189002)(199002)(99396002)(79102001)(105586002)(64706001)(83716003)(86362001)(106116001)(110136001)(19580405001)(83322001)(19580395003)(74662001)(74502001)(95666004)(92726001)(92566001)(106356001)(31966008)(77982001)(81542001)(101416001)(229853001)(36756003)(82746002)(81342001)(85852003)(83072002)(85306004)(80022001)(66066001)(50986999)(107046002)(21056001)(15975445006)(46102001)(76482001)(20776003)(2656002)(87936001)(33656002)(54356999)(4396001)(15395725005)(15202345003)(104396001);DIR:OUT;SFP:;SCL:1;SRVR:DBXPR07MB477;H:DBXPR07MB480.eurprd07.prod.outlook.com;FPR:;MLV:sfv;PTR:InfoNoRecords;MX:1;LANG:en; Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: shapeblue.com X-Virus-Checked: Checked by ClamAV on apache.org Hi, With reference to https://issues.apache.org/jira/browse/CLOUDSTACK-5512 Mar= cus and I think we should remove the template URL format checking logic bec= ause: - It does not handle pre-signed URL (say something that does not end with .= vhd etc, but has bunch of http params) - One can game the system by say renaming any file to respective format - We dumb down, take whatever URL user gives and use the format they specif= y in their register template API call Marcus also notes that TemplateUtils utility would validate selected format= . Please discuss if you=92ve any use-case that can get affected by this? Regards, Rohit Yadav Software Architect, ShapeBlue M. +41 779015219 | rohit.yadav@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design & Build CSForge =96 rapid IaaS deployment framework CloudStack Consulting CloudStack Infrastructure Support CloudStack Bootcamp Training Courses This email and any attachments to it may be confidential and are intended s= olely for the use of the individual to whom it is addressed. Any views or o= pinions expressed are solely those of the author and do not necessarily rep= resent those of Shape Blue Ltd or related companies. If you are not the int= ended recipient of this email, you must neither take any action based upon = its contents, nor copy or show it to anyone. Please contact the sender if y= ou believe you have received this email in error. Shape Blue Ltd is a compa= ny incorporated in England & Wales. ShapeBlue Services India LLP is a compa= ny incorporated in India and is operated under license from Shape Blue Ltd.= Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and= is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a c= ompany registered by The Republic of South Africa and is traded under licen= se from Shape Blue Ltd. ShapeBlue is a registered trademark.