Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8499A112EE for ; Tue, 5 Aug 2014 12:30:33 +0000 (UTC) Received: (qmail 2068 invoked by uid 500); 5 Aug 2014 12:30:33 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 2043 invoked by uid 500); 5 Aug 2014 12:30:33 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 2031 invoked by uid 99); 5 Aug 2014 12:30:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2014 12:30:32 +0000 X-ASF-Spam-Status: No, hits=-0.1 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jayapalreddy.uradi@citrix.com designates 103.14.252.240 as permitted sender) Received: from [103.14.252.240] (HELO SMTP.CITRIX.COM.AU) (103.14.252.240) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2014 12:30:28 +0000 X-IronPort-AV: E=Sophos;i="5.01,804,1400025600"; d="scan'208,217";a="8672837" From: Jayapal Reddy Uradi To: Namita Chaudhari , cloudstack Subject: Re: Review Request 24306: Review request for CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports Thread-Topic: Review Request 24306: Review request for CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports Thread-Index: AQHPsJQqKG5OMbqKS0KVgb2mbB/RxpvBahIAgAAAoAA= Date: Tue, 5 Aug 2014 12:30:04 +0000 Message-ID: <2E74466E-7CAA-4CB7-9F47-08F19D80CBE5@citrix.com> References: <20140805100035.1595.69215@reviews.apache.org> <20140805122750.1587.65736@reviews.apache.org> In-Reply-To: <20140805122750.1587.65736@reviews.apache.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: multipart/alternative; boundary="_000_2E74466E7CAA4CB79F4708F19D80CBE5citrixcom_" MIME-Version: 1.0 X-DLP: SIN1 X-Virus-Checked: Checked by ClamAV on apache.org --_000_2E74466E7CAA4CB79F4708F19D80CBE5citrixcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Namita, The patch is applied on master. Please close the review ticket. Thanks, Jayapal On 05-Aug-2014, at 5:57 PM, Jayapal Reddy > wrote: This is an automatically generated e-mail. To reply, visit: https://reviews= .apache.org/r/24306/ Ship it! Ship It! - Jayapal Reddy On August 5th, 2014, 10 a.m. UTC, Namita Chaudhari wrote: Review request for cloudstack and Jayapal Reddy. By Namita Chaudhari. Updated Aug. 5, 2014, 10 a.m. Bugs: CLOUDSTACK-2694, https://issues.apache.org/jira/browse/CLOUDSTACK-2694 Repository: cloudstack-git Description CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule= with protocol and no ports When a duplicate firewall rule is created with same cidr, protocol and no p= orts, an error popup appears for duplicate firewall rule. Testing Testing done based on the test cases updated in the bug. Diffs * server/src/com/cloud/network/firewall/FirewallManagerImpl.java (dd928= d8) View Diff --_000_2E74466E7CAA4CB79F4708F19D80CBE5citrixcom_--