Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24B8F11203 for ; Thu, 28 Aug 2014 21:07:42 +0000 (UTC) Received: (qmail 40788 invoked by uid 500); 28 Aug 2014 21:07:41 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 40738 invoked by uid 500); 28 Aug 2014 21:07:41 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 40724 invoked by uid 99); 28 Aug 2014 21:07:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Aug 2014 21:07:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 19FFC1DD2A5; Thu, 28 Aug 2014 21:07:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0563657246440928766==" MIME-Version: 1.0 Subject: Re: Review Request 25065: pre-add all RewriteRule entries to metadata htaccess file for system vm routers From: "Fred Clift" To: "Fred Clift" , "Sebastien Goasguen" , "cloudstack" Date: Thu, 28 Aug 2014 21:07:41 -0000 Message-ID: <20140828210741.17464.95031@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Fred Clift" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/25065/ X-Sender: "Fred Clift" References: <20140828210636.17464.56916@reviews.apache.org> In-Reply-To: <20140828210636.17464.56916@reviews.apache.org> Reply-To: "Fred Clift" X-ReviewRequest-Repository: cloudstack-git --===============0563657246440928766== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25065/ ----------------------------------------------------------- (Updated Aug. 28, 2014, 3:07 p.m.) Review request for cloudstack. Repository: cloudstack-git Description (updated) ------- pre-add all RewriteRule entries to metadata htaccess file for system vm routers- makes automated router maintanince easier... The set is static and doesn't ever change after the initial provision - it is identical for every router... Fix htaccess file, vmdata.py that used to modify it, and added comments to producers of meta-data to note the new usage We (betterservers.com) have some in-house router-fixing scripts that would like to re-unpack the tarball and not loose the full .htaccess file... Diffs ----- core/test/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResourceTest.java aab1e72 plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java e133f7d server/src/com/cloud/network/element/CloudZonesNetworkElement.java 55cd5fa server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 33d7cd7 systemvm/patches/debian/config/opt/cloud/bin/vmdata.py a44c134 systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9 Diff: https://reviews.apache.org/r/25065/diff/ Testing ------- installed cloudstack, set up networks and provisioned a vm - made sure the router got the same .htaccess file that it would normally get after the first vm is added to the network Thanks, Fred Clift --===============0563657246440928766==--