Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B4D6B110E0 for ; Mon, 18 Aug 2014 06:31:22 +0000 (UTC) Received: (qmail 26806 invoked by uid 500); 18 Aug 2014 06:31:22 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 26758 invoked by uid 500); 18 Aug 2014 06:31:22 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 26739 invoked by uid 99); 18 Aug 2014 06:31:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Aug 2014 06:31:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 600991DBD20; Mon, 18 Aug 2014 06:31:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4024888503002286549==" MIME-Version: 1.0 Subject: Re: Review Request 24226: CLOUDSTACK-7234: stop sending smb credentials to Hyper-V Agent From: "Devdeep Singh" To: "Rajesh Battala" , "Devdeep Singh" Cc: "Anshul Gangwar" , "cloudstack" Date: Mon, 18 Aug 2014 06:31:21 -0000 Message-ID: <20140818063121.7608.37352@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Devdeep Singh" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/24226/ X-Sender: "Devdeep Singh" References: <20140804060852.1586.29569@reviews.apache.org> In-Reply-To: <20140804060852.1586.29569@reviews.apache.org> Reply-To: "Devdeep Singh" X-ReviewRequest-Repository: cloudstack-git --===============4024888503002286549== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24226/#review50862 ----------------------------------------------------------- Ship it! Pushed to master in commit 0ecc9f79af0f915ac347f856c3c2f8ce40f636af - Devdeep Singh On Aug. 4, 2014, 6:08 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24226/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 6:08 a.m.) > > > Review request for cloudstack, Devdeep Singh and Rajesh Battala. > > > Bugs: CLOUDSTACK-7234 > https://issues.apache.org/jira/browse/CLOUDSTACK-7234 > > > Repository: cloudstack-git > > > Description > ------- > > We no longer uses SMB credentials on Hyper-V Agent so we are stopping to send SMB credentials to Hyper-V > > > Diffs > ----- > > engine/schema/src/org/apache/cloudstack/storage/datastore/db/StoragePoolVO.java 1508ce0 > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/CloudStackTypes.cs 4516191 > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/Utils.cs b40cb8f > plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java 2671b20 > > Diff: https://reviews.apache.org/r/24226/diff/ > > > Testing > ------- > > verified on Hyper-V agent that we are not receiving SMB credentials. > > > Thanks, > > Anshul Gangwar > > --===============4024888503002286549==--