Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4F4DB11F7D for ; Mon, 18 Aug 2014 05:36:30 +0000 (UTC) Received: (qmail 45329 invoked by uid 500); 18 Aug 2014 05:36:29 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 45271 invoked by uid 500); 18 Aug 2014 05:36:29 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 45248 invoked by uid 99); 18 Aug 2014 05:36:29 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Aug 2014 05:36:29 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C81881DBD20; Mon, 18 Aug 2014 05:36:28 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6612567708415790840==" MIME-Version: 1.0 Subject: Re: Review Request 24055: CLOUDSTACK-2251: Automation test cases for feature - Dedicated guest VLAN ranges per tenant From: "sanjeev n" To: "sailaja mada" , "suresh sadhu" , "sanjeev n" , "Sowmya Krishnan" Cc: "Ashutosh Kelkar" , "cloudstack" Date: Mon, 18 Aug 2014 05:36:28 -0000 Message-ID: <20140818053628.7609.63528@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "sanjeev n" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/24055/ X-Sender: "sanjeev n" References: <20140729142038.21934.8356@reviews.apache.org> In-Reply-To: <20140729142038.21934.8356@reviews.apache.org> Reply-To: "sanjeev n" X-ReviewRequest-Repository: cloudstack-git --===============6612567708415790840== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24055/#review50850 ----------------------------------------------------------- test/integration/component/test_dedicate_guest_vlan_ranges.py Add assertions to check whether the vlan dedecation is success or not. Applies to account2 as well. test/integration/component/test_dedicate_guest_vlan_ranges.py Add assertion since this is where the actual test is happening. test/integration/component/test_dedicate_guest_vlan_ranges.py This assert statement does not make sense because no vlan would be assigned to the network created here. Not sure what would be the value of netowrks[0].vlan when there is no vlan assigned for the network. test/integration/component/test_dedicate_guest_vlan_ranges.py Not catching the exception if releasing vlan range fails for some reason. Add code to handle the error in releasing vlan range. - sanjeev n On July 29, 2014, 2:20 p.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24055/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 2:20 p.m.) > > > Review request for cloudstack, suresh sadhu, sailaja mada, sanjeev n, and Sowmya Krishnan. > > > Bugs: CLOUDSTACK-2251 > https://issues.apache.org/jira/browse/CLOUDSTACK-2251 > > > Repository: cloudstack-git > > > Description > ------- > > Automation test cases for feature - Dedicated guest VLAN ranges per tenant > > > Diffs > ----- > > test/integration/component/test_dedicate_guest_vlan_ranges.py PRE-CREATION > tools/marvin/marvin/lib/base.py 58033c6 > tools/marvin/marvin/lib/common.py 187ede6 > > Diff: https://reviews.apache.org/r/24055/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Ashutosh Kelkar > > --===============6612567708415790840==--