Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EB69A118EC for ; Wed, 13 Aug 2014 10:05:56 +0000 (UTC) Received: (qmail 63723 invoked by uid 500); 13 Aug 2014 10:05:56 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 63674 invoked by uid 500); 13 Aug 2014 10:05:56 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 63660 invoked by uid 99); 13 Aug 2014 10:05:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Aug 2014 10:05:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D03521D9D89; Wed, 13 Aug 2014 10:05:55 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8740192407406872068==" MIME-Version: 1.0 Subject: Re: Review Request 24550: CLOUDSTACK-7306 Don't run test_01_primary_storage_iscsi on KVM or HyperV From: "Santhosh Edukulla" To: "Santhosh Edukulla" Cc: "Alex Brett" , "cloudstack" Date: Wed, 13 Aug 2014 10:05:55 -0000 Message-ID: <20140813100555.27785.77519@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Santhosh Edukulla" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/24550/ X-Sender: "Santhosh Edukulla" References: <20140811142813.10843.71334@reviews.apache.org> In-Reply-To: <20140811142813.10843.71334@reviews.apache.org> Reply-To: "Santhosh Edukulla" X-ReviewRequest-Repository: cloudstack-git --===============8740192407406872068== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24550/#review50440 ----------------------------------------------------------- Patch failed to apply on master. error: patch failed: test/integration/smoke/test_primary_storage.py:146 error: test/integration/smoke/test_primary_storage.py: patch does not apply - Santhosh Edukulla On Aug. 11, 2014, 2:28 p.m., Alex Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24550/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 2:28 p.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7306 > https://issues.apache.org/jira/browse/CLOUDSTACK-7306 > > > Repository: cloudstack-git > > > Description > ------- > > test_01_primary_storage_iscsi in test/integration/smoke/test_primary_storage.py currently attempts to set up an iSCSI primary storage pool, regardless of the type of host. > > For KVM, we only support iSCSI via shared mount point, and for Hyper-V we don't support it at all, so the test should skip in these cases. > > > Diffs > ----- > > test/integration/smoke/test_primary_storage.py 66aec59 > > Diff: https://reviews.apache.org/r/24550/diff/ > > > Testing > ------- > > Ran test against KVM host to verify it skips correctly > > > Thanks, > > Alex Brett > > --===============8740192407406872068==--