Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BFA7D113B4 for ; Tue, 12 Aug 2014 13:59:08 +0000 (UTC) Received: (qmail 64108 invoked by uid 500); 12 Aug 2014 13:59:08 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 64060 invoked by uid 500); 12 Aug 2014 13:59:08 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 64044 invoked by uid 99); 12 Aug 2014 13:59:07 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Aug 2014 13:59:07 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 720C01DB6D3; Tue, 12 Aug 2014 13:58:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5942580674194156228==" MIME-Version: 1.0 Subject: Re: Review Request 24599: CLOUDSTACK-7284: Fixed test script related to expunge VM in test_add_remove_network.py From: "ASF Subversion and Git Services" To: "Doug Clark" , "Santhosh Edukulla" Cc: "Gaurav Aradhye" , "ASF Subversion and Git Services" , "cloudstack" Date: Tue, 12 Aug 2014 13:58:53 -0000 Message-ID: <20140812135853.10843.8764@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/24599/ X-Sender: "ASF Subversion and Git Services" References: <20140812110452.10843.7864@reviews.apache.org> In-Reply-To: <20140812110452.10843.7864@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" X-ReviewRequest-Repository: cloudstack-git --===============5942580674194156228== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24599/#review50322 ----------------------------------------------------------- Commit 97ecd5575c4b408ecb4e08a1b81933bb703b324a in cloudstack's branch refs/heads/master from Girish Shilamkar [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=97ecd55 ] CLOUDSTACK-7284: Fixed cleanup issue in test_escalations_instances.py, VM should be deleted before deleting the network - ASF Subversion and Git Services On Aug. 12, 2014, 11:04 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24599/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2014, 11:04 a.m.) > > > Review request for cloudstack, Doug Clark and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7284 > https://issues.apache.org/jira/browse/CLOUDSTACK-7284 > > > Repository: cloudstack-git > > > Description > ------- > > The test case was failing while listing the VM after destroying it and verifying that it is destroyed. > As now by default it will be expunged, there is no need of this code snippet which lists VM and verifies that it is being expunged. > > > Diffs > ----- > > test/integration/component/test_add_remove_network.py 2bd6ec2 > > Diff: https://reviews.apache.org/r/24599/diff/ > > > Testing > ------- > > Yes. > > Log: > update default nic of vm when vm is state is not Running or Stopped ... === TestName: test_23_update_nic_incorrect_vm_state | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 1 test in 394.165s > > OK > > > Thanks, > > Gaurav Aradhye > > --===============5942580674194156228==--