Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F10A311B9C for ; Wed, 6 Aug 2014 10:07:36 +0000 (UTC) Received: (qmail 36732 invoked by uid 500); 6 Aug 2014 10:07:36 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 36684 invoked by uid 500); 6 Aug 2014 10:07:36 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 36667 invoked by uid 99); 6 Aug 2014 10:07:36 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Aug 2014 10:07:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F2AF71D9E0F; Wed, 6 Aug 2014 10:07:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8814431718572781515==" MIME-Version: 1.0 Subject: Review Request 24378: CLOUDSTACK-7268: Ignore "already exists" error in createEgressFirewallRule From: "John Dilley" To: "Santhosh Edukulla" Cc: "John Dilley" , "cloudstack" Date: Wed, 06 Aug 2014 10:07:21 -0000 Message-ID: <20140806100721.1586.76719@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "John Dilley" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/24378/ X-Sender: "John Dilley" Reply-To: "John Dilley" X-ReviewRequest-Repository: cloudstack-git --===============8814431718572781515== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24378/ ----------------------------------------------------------- Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7268 https://issues.apache.org/jira/browse/CLOUDSTACK-7268 Repository: cloudstack-git Description ------- Although we could search for an existing firewall rule, this fix is simpler, and also less prone to race conditions if multiple threads are running. Diffs ----- tools/marvin/marvin/lib/base.py 3a1f7e6 Diff: https://reviews.apache.org/r/24378/diff/ Testing ------- Tested on KVM advanced zone Thanks, John Dilley --===============8814431718572781515==--