Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9A79311B2D for ; Wed, 6 Aug 2014 09:49:41 +0000 (UTC) Received: (qmail 6117 invoked by uid 500); 6 Aug 2014 09:49:41 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 6066 invoked by uid 500); 6 Aug 2014 09:49:41 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 6051 invoked by uid 99); 6 Aug 2014 09:49:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Aug 2014 09:49:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 07E831D9E0F; Wed, 6 Aug 2014 09:49:27 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6078140830371158192==" MIME-Version: 1.0 Subject: Re: Review Request 24313: CLOUDSTACK-7255: Fixed marvin issue related to creating random account usernames From: "Gaurav Aradhye" To: "Santhosh Edukulla" Cc: "Gaurav Aradhye" , "cloudstack" Date: Wed, 06 Aug 2014 09:49:27 -0000 Message-ID: <20140806094927.1587.47595@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gaurav Aradhye" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/24313/ X-Sender: "Gaurav Aradhye" References: <20140805140722.1587.36322@reviews.apache.org> In-Reply-To: <20140805140722.1587.36322@reviews.apache.org> Reply-To: "Gaurav Aradhye" X-ReviewRequest-Repository: cloudstack-git --===============6078140830371158192== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24313/ ----------------------------------------------------------- (Updated Aug. 6, 2014, 3:19 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7255 https://issues.apache.org/jira/browse/CLOUDSTACK-7255 Repository: cloudstack-git Description ------- Few test cases failed with "Entity already exists" while creating account because the account name already existed in the setup. We append random string to the username to make account names unique. Also the account name should be less than 99 chars. But in case where the original username becomes greater than 99 chars, appending random string to it and trimming it back to 99 chars does not make any difference to the original string. In this case the username should be trimmed first and then random string should be appended to make the account name unique. Diffs (updated) ----- tools/marvin/marvin/lib/base.py 3a1f7e6 Diff: https://reviews.apache.org/r/24313/diff/ Testing ------- Yes. Test router internal basic zone ... SKIP: Marvin configuration has no host credentials to check router services ---------------------------------------------------------------------- Ran 1 test in 141.558s OK (SKIP=1) Thanks, Gaurav Aradhye --===============6078140830371158192==--