Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 264C611215 for ; Tue, 5 Aug 2014 12:03:47 +0000 (UTC) Received: (qmail 32598 invoked by uid 500); 5 Aug 2014 12:03:46 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 32554 invoked by uid 500); 5 Aug 2014 12:03:46 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 32540 invoked by uid 99); 5 Aug 2014 12:03:46 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2014 12:03:46 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 991281D9E8E; Tue, 5 Aug 2014 12:03:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1614917216846666756==" MIME-Version: 1.0 Subject: Re: Review Request 24305: CLOUDSTACK-7240: Fixed expunge VM issue in test_persistent_networks.py From: "Gaurav Aradhye" To: "Santhosh Edukulla" Cc: "Gaurav Aradhye" , "ASF Subversion and Git Services" , "cloudstack" Date: Tue, 05 Aug 2014 12:03:32 -0000 Message-ID: <20140805120332.1587.46420@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Gaurav Aradhye" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/24305/ X-Sender: "Gaurav Aradhye" References: <20140805094535.1587.14504@reviews.apache.org> In-Reply-To: <20140805094535.1587.14504@reviews.apache.org> Reply-To: "Gaurav Aradhye" X-ReviewRequest-Repository: cloudstack-git --===============1614917216846666756== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24305/ ----------------------------------------------------------- (Updated Aug. 5, 2014, 5:33 p.m.) Review request for cloudstack and Santhosh Edukulla. Bugs: CLOUDSTACK-7240 https://issues.apache.org/jira/browse/CLOUDSTACK-7240 Repository: cloudstack-git Description ------- Fixed the VM expunge code. The delete method was called twice, and also expunge=True parameter is not needed now as it is by default True. Diffs ----- test/integration/component/test_persistent_networks.py 210063e Diff: https://reviews.apache.org/r/24305/diff/ Testing ------- Yes. test_network_state_after_destroying_vms (test_persistent_networks.TestPersistentNetworks) ... === TestName: test_network_state_after_destroying_vms | Status : SUCCESS === ok ---------------------------------------------------------------------- Ran 1 test in 437.852s OK Thanks, Gaurav Aradhye --===============1614917216846666756==--