cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Dilley" <john.dil...@citrix.com>
Subject Re: Review Request 24420: vGPU Test Automation ( Check for vGPU resources & VM lifecycle tests)
Date Fri, 22 Aug 2014 09:19:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24420/#review51272
-----------------------------------------------------------



test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89415>

    Why while rather than if?



test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89417>

    Turn while into if above, get rid of this if, and put the following line under "if k1hosts
!= 0" above



test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89420>

    Don't hardcode "Group of NVIDIA Corporation GK104GL [GRID K1] GPUs" into the test, run
gpu-group-list on the host instead



test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89418>

    Same comment as above



test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89419>

    Same comment as above



test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89416>

    Don't hardcode "Group of NVIDIA Corporation GK104GL [GRID K2] GPUs" into the test, run
gpu-group-list on the host instead



test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89421>

    use "xe vgpu-list vm-name-label=<vminstancename> params=<param name> --minimal",
then you can get rid of most of the subsequent lines



test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89422>

    In particular, relying on the type parameter being in position 8 is likely to be fragile
- XenServer doesn't guarentee the order of the parameters. Future versions could add a parameter
and break this



test/integration/component/test_deploy_vgpu_vm.py
<https://reviews.apache.org/r/24420/#comment89423>

    Give the test a different name, because it doesn't actually deploy a VM.


- John Dilley


On Aug. 21, 2014, 12:33 p.m., abhinav roy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24420/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2014, 12:33 p.m.)
> 
> 
> Review request for cloudstack, Doug Clark, sailaja mada, and Sanjay Tripathi.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This Diff includes vGPU VM lifecycle tests as well as a function to validate the vGPU
resources present in a vGPU VM deployed on CS. It has the following tests :
> 
> 1. A function to validate vGPU resources in a VM. It does validation on both the host
as well as on CS.
>    It includes following lifecycle tests.
>    
> 
> 2. Deploy VM
> 3. Stop VM
> 4. Start VM
> 5. Restore VM
> 6. Reboot VM
> 7. Destroy VM
> 8. Recover VM
> 
> 
> NOTE : VM lifecycle test cases were included in this script after the 1st rouund of review
with Doug. We decided to include those tests here just to remove the overhead of registering
template again. so, now there is no use of this review request https://reviews.apache.org/r/24425/

> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_deploy_vgpu_vm.py fd3f374 
> 
> Diff: https://reviews.apache.org/r/24420/diff/
> 
> 
> Testing
> -------
> 
> Testing :
> 
> 1. Executed the script on non GPU test setup and ensured tests being skipped. 
> 2. Executed on K2 GPU drivers installed setup and ensured all lifecycle test cases are
working fine and the function is checking for the vGPU resources in a vGPU VM.
> 
> 
> Thanks,
> 
> abhinav roy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message