cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Zhou" <w.z...@leaseweb.com>
Subject Re: Review Request 24557: CLOUDSTACK-7308 - Adds tagging support for security group rules
Date Fri, 15 Aug 2014 06:46:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24557/#review50707
-----------------------------------------------------------

Ship it!


Ship It!

- Wei Zhou


On 八月 12, 2014, 2:39 p.m., Stephen Hoogendijk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24557/
> -----------------------------------------------------------
> 
> (Updated 八月 12, 2014, 2:39 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland and Wei Zhou.
> 
> 
> Bugs: CLOUDSTACK-7308
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7308
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Adds tagging support for security group rules.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/server/ResourceTag.java d91bb7d 
>   api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java e2d525a 
>   server/src/com/cloud/api/query/dao/SecurityGroupJoinDaoImpl.java 093709d 
>   server/src/com/cloud/tags/TaggedResourceManagerImpl.java e6f317c 
> 
> Diff: https://reviews.apache.org/r/24557/diff/
> 
> 
> Testing
> -------
> 
> api tested with cloudmonkey (create tags, list tags, list security groups). No exceptions
were found.
> 
> 
> Thanks,
> 
> Stephen Hoogendijk
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message