cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Dilley" <john.dil...@citrix.com>
Subject Re: Review Request 24696: Only attempt to shrink volume in test if CLVM is in use
Date Thu, 14 Aug 2014 11:20:04 GMT


> On Aug. 14, 2014, 11:16 a.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_volumes.py, line 640
> > <https://reviews.apache.org/r/24696/diff/1/?file=660476#file660476line640>
> >
> >     Just an additional refactor, we can do the check at the start before attach
volume and skip, this reduces some time if these are not applicable for vmware and hyperv

This has nothing to do with the bug I'm fixing, so should be addressed in a different patch.


> On Aug. 14, 2014, 11:16 a.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_volumes.py, line 712
> > <https://reviews.apache.org/r/24696/diff/1/?file=660476#file660476line712>
> >
> >     This code was redundant in the same test case twice for both resize commands.May
be we can refactor here as well, as such we have touched the test case.

This has nothing to do with the bug I'm fixing, so should be addressed in a different patch.


> On Aug. 14, 2014, 11:16 a.m., Santhosh Edukulla wrote:
> > test/integration/smoke/test_volumes.py, line 734
> > <https://reviews.apache.org/r/24696/diff/1/?file=660476#file660476line734>
> >
> >     My point was, what is the significance of this logic "if possible to shrink",
start vm can still be possible with out previous if, so what check additionally we do if or
if not for previous if?

I don't follow? If the hypervisor is XenServer, we want to attempt to restart the VM at the
end of the test, regardless of whether or not we attempted to shrink the volume. That's why
this code hasn't changed, and isn't in the new "if can_shrink" block.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24696/#review50572
-----------------------------------------------------------


On Aug. 14, 2014, 10:42 a.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24696/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 10:42 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7228
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7228
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently only CLVM supports shrinking volumes. This patch will only attempt to shrink
a volume if CLVM is in use.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py e2e0d76 
> 
> Diff: https://reviews.apache.org/r/24696/diff/
> 
> 
> Testing
> -------
> 
> Tested on XenServer to check that the test now passes.
> 
> 
> Thanks,
> 
> John Dilley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message