cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Dilley" <john.dil...@citrix.com>
Subject Re: Review Request 24696: Only attempt to shrink volume in test if CLVM is in use
Date Thu, 14 Aug 2014 11:08:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24696/#review50571
-----------------------------------------------------------



test/integration/smoke/test_volumes.py
<https://reviews.apache.org/r/24696/#comment88434>

    There's a bit at the top where we stop the VM if it's XenServer. This is to check that
after the appropraite resize operations, we can actually start the VM again.
    
    I've not indented it with everything else. The logic goes something like this
    
    if xenserver:
        stop vm
    
    grow volume
    
    if possible to shrink:
       shrink volume
       
    if xenserver:
        start vm again to check it can still run


- John Dilley


On Aug. 14, 2014, 10:42 a.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24696/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 10:42 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7228
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7228
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Currently only CLVM supports shrinking volumes. This patch will only attempt to shrink
a volume if CLVM is in use.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_volumes.py e2e0d76 
> 
> Diff: https://reviews.apache.org/r/24696/diff/
> 
> 
> Testing
> -------
> 
> Tested on XenServer to check that the test now passes.
> 
> 
> Thanks,
> 
> John Dilley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message