cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 22939: CLOUDSTACK-6460 - CLVM primary storage migration fails due to incorrect identification of source format.
Date Fri, 08 Aug 2014 08:38:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22939/#review50023
-----------------------------------------------------------


Commit 536ec0578111cf85e93122deaf9a95270d66f778 in cloudstack's branch refs/heads/hotfix/4.4-6460
from Simon Weller
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=536ec05 ]

CLOUDSTACK-6460 - Force RAW when storage type is CLVM. Fixes primary storage migration for
CLVM

Signed-off-by: Daan Hoogland <daan@onecht.net>


- ASF Subversion and Git Services


On July 23, 2014, 4:30 p.m., Simon Weller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22939/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 4:30 p.m.)
> 
> 
> Review request for cloudstack, edison su and Marcus Sorensen.
> 
> 
> Bugs: CLOUDSTACK-6460
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6460
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Addresses CLOUDSTACK-6460.
> CLVM storage source was being identified as QCOW2, rather than raw when attempting a
primary storage migration.  This caused the migration to fail when qemu-img attempted to image
the file back from secondary storage to the new primary storage selected. This patch forces
CLVM to be treated as RAW while continuing to acquire sourceFormat from other storage types
via disk.getFormat();
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
ecf3e08 
> 
> Diff: https://reviews.apache.org/r/22939/diff/
> 
> 
> Testing
> -------
> 
> Stop VM. Migrate from one primary storage to another. Migration completes successfully.
Start vm.
> 
> 
> Thanks,
> 
> Simon Weller
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message