cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Dilley" <john.dil...@citrix.com>
Subject Re: Review Request 24378: CLOUDSTACK-7268: Ignore "already exists" error in createEgressFirewallRule
Date Thu, 07 Aug 2014 07:41:56 GMT


> On Aug. 7, 2014, 7:21 a.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/lib/base.py, line 350
> > <https://reviews.apache.org/r/24378/diff/1/?file=653687#file653687line350>
> >
> >     may be to keep simple check if not string in e.. and raise, pass can be removed.
As well, is the exception thrown is only cloudstackAPIException or some other type? add a
default handler if possible and fail in case so?
> >     
> >     Do a lower comparison of message again for both left and right hand vlaue.

The failure we want to ignore will always be cloudstackAPI exception. Any other type of exception
will not match an except block, so will be raised rather than handled.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24378/#review49877
-----------------------------------------------------------


On Aug. 7, 2014, 7:41 a.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24378/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2014, 7:41 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7268
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7268
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Although we could search for an existing firewall rule, this fix is simpler, and also
less prone to race conditions if multiple threads are running.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/lib/base.py 3a1f7e6 
> 
> Diff: https://reviews.apache.org/r/24378/diff/
> 
> 
> Testing
> -------
> 
> Tested on KVM advanced zone
> 
> 
> Thanks,
> 
> John Dilley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message