cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Dilley" <john.dil...@citrix.com>
Subject Re: Review Request 24378: CLOUDSTACK-7268: Ignore "already exists" error in createEgressFirewallRule
Date Thu, 07 Aug 2014 07:41:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24378/
-----------------------------------------------------------

(Updated Aug. 7, 2014, 7:41 a.m.)


Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-7268
    https://issues.apache.org/jira/browse/CLOUDSTACK-7268


Repository: cloudstack-git


Description
-------

Although we could search for an existing firewall rule, this fix is simpler, and also less
prone to race conditions if multiple threads are running.


Diffs (updated)
-----

  tools/marvin/marvin/lib/base.py 3a1f7e6 

Diff: https://reviews.apache.org/r/24378/diff/


Testing
-------

Tested on KVM advanced zone


Thanks,

John Dilley


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message