cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jayapal Reddy" <jayapalreddy.ur...@citrix.com>
Subject Re: Review Request 24306: Review request for CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol and no ports
Date Tue, 05 Aug 2014 12:27:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24306/#review49593
-----------------------------------------------------------

Ship it!


Ship It!

- Jayapal Reddy


On Aug. 5, 2014, 10 a.m., Namita Chaudhari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24306/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 10 a.m.)
> 
> 
> Review request for cloudstack and Jayapal Reddy.
> 
> 
> Bugs: CLOUDSTACK-2694 and https://issues.apache.org/jira/browse/CLOUDSTACK-2694
>     https://issues.apache.org/jira/browse/CLOUDSTACK-2694
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-2694
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2694 - [Firewall Rule] Able to configure duplicate firewall rule with protocol
and no ports 
> 
> When a duplicate firewall rule is created with same cidr, protocol and no ports, an error
popup appears for duplicate firewall rule.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/firewall/FirewallManagerImpl.java dd928d8 
> 
> Diff: https://reviews.apache.org/r/24306/diff/
> 
> 
> Testing
> -------
> 
> Testing done based on the test cases updated in the bug.
> 
> 
> Thanks,
> 
> Namita Chaudhari
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message