cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 24305: CLOUDSTACK-7240: Fixed expunge VM issue in test_persistent_networks.py
Date Tue, 05 Aug 2014 12:01:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24305/#review49589
-----------------------------------------------------------

Ship it!


Ship It!

- Santhosh Edukulla


On Aug. 5, 2014, 9:45 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24305/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2014, 9:45 a.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7240
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7240
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed the VM expunge code. The delete method was called twice, and also expunge=True
parameter is not needed now as it is by default True.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_persistent_networks.py 210063e 
> 
> Diff: https://reviews.apache.org/r/24305/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> test_network_state_after_destroying_vms (test_persistent_networks.TestPersistentNetworks)
... === TestName: test_network_state_after_destroying_vms | Status : SUCCESS
> ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 437.852s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message