cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leo Simons" <leosim...@apache.org>
Subject Re: Review Request 24238: Fix mvn marvin.sync profile
Date Tue, 05 Aug 2014 08:43:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24238/
-----------------------------------------------------------

(Updated Aug. 5, 2014, 8:43 a.m.)


Review request for cloudstack and Rohit Yadav.


Changes
-------

Implemented the alternative solution proposed by Rohit.


Repository: cloudstack-git


Description
-------

Commit e10f8e887571e28f31dbcf02a0beac163a901fe1 broke
  mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
Because the maven file had hard-coded 0.1.0.

This fix removes the hard-coding completely, by having the python setup read
the version from the maven pom.xml, and the maven setup using its version.


Diffs (updated)
-----

  tools/marvin/mvn-setup.py PRE-CREATION 
  tools/marvin/pom.xml 3bf70e041c6bab051d7a184ff9c3c81ea31d2054 
  tools/marvin/setup.py 555d67dfc491cf5ab52d36b417a6b5842ea6ad96 

Diff: https://reviews.apache.org/r/24238/diff/


Testing
-------

Commands that work now for me include:

mvn -X -Pdeveloper,marvin.sync -Dendpoint=localhost -pl :cloud-marvin
python setup.py install
python setup.py develop
mvn -P developer -pl :cloud-marvin


Thanks,

Leo Simons


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message