cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 24182: CLOUDSTACK-7223 Wait for System VM agent state to be connected before verication
Date Fri, 01 Aug 2014 15:11:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24182/#review49340
-----------------------------------------------------------



test/integration/smoke/test_ssvm.py
<https://reviews.apache.org/r/24182/#comment86336>

    Then, we can remove this sleep. Applies at other places as well.



test/integration/smoke/test_ssvm.py
<https://reviews.apache.org/r/24182/#comment86337>

    This is good actually, but can we make this code, a util\lib, such that this repetition
can be avoided. That way others can reuse it and lines of code will reduce. You can decide
the signature for that util.



test/integration/smoke/test_ssvm.py
<https://reviews.apache.org/r/24182/#comment86338>

    just check the length of list to be empty other wise we may get index out of range error
and do a lower conversion string comparison.


- Santhosh Edukulla


On Aug. 1, 2014, 1:43 p.m., John Dilley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24182/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2014, 1:43 p.m.)
> 
> 
> Review request for cloudstack and Santhosh Edukulla.
> 
> 
> Bugs: CLOUDSTACK-7223
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7223
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This change waits for the system VM agent state to be up in the testcases that stop/reboot/destroy
system VMs before verifying that they are functioning properly.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_ssvm.py ac4079e 
> 
> Diff: https://reviews.apache.org/r/24182/diff/
> 
> 
> Testing
> -------
> 
> Tested against KVM advanced zone
> 
> 
> Thanks,
> 
> John Dilley
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message