Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C3632112AE for ; Fri, 18 Jul 2014 14:57:50 +0000 (UTC) Received: (qmail 79200 invoked by uid 500); 18 Jul 2014 14:57:50 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 79155 invoked by uid 500); 18 Jul 2014 14:57:50 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 79139 invoked by uid 99); 18 Jul 2014 14:57:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jul 2014 14:57:49 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of rsabharw@brocade.com designates 67.231.144.122 as permitted sender) Received: from [67.231.144.122] (HELO mx0a-000f0801.pphosted.com) (67.231.144.122) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jul 2014 14:57:43 +0000 Received: from pps.filterd (m0048193 [127.0.0.1]) by mx0a-000f0801.pphosted.com (8.14.5/8.14.5) with SMTP id s6IEnlfF000585; Fri, 18 Jul 2014 07:57:22 -0700 Received: from hq1wp-exchub02.corp.brocade.com ([144.49.131.13]) by mx0a-000f0801.pphosted.com with ESMTP id 1n704ws0m8-2 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Fri, 18 Jul 2014 07:57:21 -0700 Received: from HQ1WP-EXHUB01.corp.brocade.com (10.70.36.14) by hq1wp-exchub02.corp.brocade.com (10.70.38.99) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 18 Jul 2014 07:57:18 -0700 Received: from HQ1-EXCH03.corp.brocade.com ([fe80::b84d:57f5:e24b:1e00]) by HQ1WP-EXHUB01.corp.brocade.com ([fe80::55ee:533:4b9d:a097%12]) with mapi; Fri, 18 Jul 2014 07:57:18 -0700 From: Ritu Sabharwal To: Hugo Trippaers , "hugo@apache.org" , Hugo Trippaers CC: "dev@cloudstack.apache.org" Date: Fri, 18 Jul 2014 07:57:16 -0700 Subject: Review Request #22863 , #23314 : Brocade Plugin review request... Thread-Topic: Review Request #22863 , #23314 : Brocade Plugin review request... Thread-Index: Ac+imIExMcVD0VatQwyOR26OHgS0JQ== Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: multipart/alternative; boundary="_000_EDD8E64855FBDA45ACDFE02112E795B7069BF08214HQ1EXCH03corp_" MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52,1.0.14,0.0.0000 definitions=2014-07-18_03:2014-07-18,2014-07-18,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1407180165 X-Virus-Checked: Checked by ClamAV on apache.org --_000_EDD8E64855FBDA45ACDFE02112E795B7069BF08214HQ1EXCH03corp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Hugo, I have fixed the 3 items as proposed by you: 1. Added the unit tests 2. Added integration test 3. Removed the configuration from properties file to networks service= provider configuration using APIs or GUI. Can you please review the plugin code so that we can make it by July 19th. Thanks for reviewing the plugin and supporting us. Thanks & Regards, Ritu S. --_000_EDD8E64855FBDA45ACDFE02112E795B7069BF08214HQ1EXCH03corp_--