Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============3461081121805924151=="
MIME-Version: 1.0
Subject: Review Request 24152: CLOUDSTACK-7182: NPE while trying to deploy VMs
 in
 parallel in isolated network
From: "Koushik Das" <koushik.das@citrix.com>
To: "Alena Prokharchyk" <alena.prokharchyk@citrix.com>,
 "Sheng Yang" <sheng@yasker.org>
Cc: "Koushik Das" <koushik.das@citrix.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Thu, 31 Jul 2014 11:53:30 -0000
Message-ID: <20140731115330.18793.75042@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Koushik Das" <noreply@reviews.apache.org>
Reply-To: "Koushik Das" <koushik.das@citrix.com>

--===============3461081121805924151==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24152/
-----------------------------------------------------------

Review request for cloudstack, Alena Prokharchyk and Sheng Yang.


Bugs: CLOUDSTACK-7182
    https://issues.apache.org/jira/browse/CLOUDSTACK-7182


Repository: cloudstack-git


Description
-------

- Check to see if network is implemented changed from 'state == Implementing||Implemented' to 'state == Implemented'. The earlier check was a hack to prevent the issue described next.
- At the time of implementing network (using implementNetwork() method), if the VR needs to be deployed then it follows the same path of regular VM deployment. This leads to a nested call to implementNetwork() while preparing VR nics. This flow creates issues in dealing with network state transitions. The original call puts network in "Implementing" state and then the nested call again tries to put it into same state resulting in issues. In order to avoid it, implementNetwork() call for VR is replaced with below code.


Diffs
-----

  engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java 64a1f3a 

Diff: https://reviews.apache.org/r/24152/diff/


Testing
-------

Ran isolated network tests using simulator.
Also ran the following VPC test using simulator:
1. created vpc, VR gets started as part of this
2. created network in the vpc
3. deployed vm in network created in step#2


Thanks,

Koushik Das


--===============3461081121805924151==--