Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A77AD108C2 for ; Wed, 23 Jul 2014 14:59:06 +0000 (UTC) Received: (qmail 20284 invoked by uid 500); 23 Jul 2014 14:59:06 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 20239 invoked by uid 500); 23 Jul 2014 14:59:06 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 20218 invoked by uid 99); 23 Jul 2014 14:59:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jul 2014 14:59:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 282B61DB52A; Wed, 23 Jul 2014 14:58:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4468187134755535411==" MIME-Version: 1.0 Subject: Re: Review Request 23847: Check if config specifies zones before iterating From: "Santhosh Edukulla" To: "daan Hoogland" , "Santhosh Edukulla" , "Hugo Trippaers" Cc: "Miguel Ferreira" , "cloudstack" Date: Wed, 23 Jul 2014 14:58:53 -0000 Message-ID: <20140723145853.4203.99557@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Santhosh Edukulla" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/23847/ X-Sender: "Santhosh Edukulla" References: <20140723121759.4204.61691@reviews.apache.org> In-Reply-To: <20140723121759.4204.61691@reviews.apache.org> Reply-To: "Santhosh Edukulla" X-ReviewRequest-Repository: cloudstack-git --===============4468187134755535411== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23847/#review48509 ----------------------------------------------------------- Ship it! Ship It! - Santhosh Edukulla On July 23, 2014, 12:17 p.m., Miguel Ferreira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23847/ > ----------------------------------------------------------- > > (Updated July 23, 2014, 12:17 p.m.) > > > Review request for cloudstack, daan Hoogland, Santhosh Edukulla, and Hugo Trippaers. > > > Repository: cloudstack-git > > > Description > ------- > > Running a marvin test that does not specify a zone in the config file will produce an exception while parsing the config: > > Exception Occurred Under init ['Traceback (most recent call last):\n', ' File "/usr/local/lib/python2.7/site-packages/marvin/marvinInit.py", line 118, in __setHypervisorAndZoneInfo\n for zone in self.__parsedConfig.zones:\n', "TypeError: 'NoneType' object is not iterable\n"] > > This happens when the code starts iterating over a list of zones that does not exist. > I've added a check for the existence of the list of zones before iterating. > > > Diffs > ----- > > tools/marvin/marvin/marvinInit.py ce9b43f > > Diff: https://reviews.apache.org/r/23847/diff/ > > > Testing > ------- > > Tests now run without the mentioned exception > > > Thanks, > > Miguel Ferreira > > --===============4468187134755535411==--