Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Content-Type: multipart/alternative;
 boundary="===============8396825898340988352=="
MIME-Version: 1.0
Subject: Re: Review Request 23847: Check if config specifies zones before
 iterating
From: "Santhosh Edukulla" <santhosh.edukulla@citrix.com>
To: "daan Hoogland" <daan.hoogland@gmail.com>,
 "Santhosh Edukulla" <santhosh.edukulla@citrix.com>,
 "Hugo Trippaers" <htrippaers@schubergphilis.com>
Cc: "Miguel Ferreira" <miguelferreira@me.com>,
 "cloudstack" <dev@cloudstack.apache.org>
Date: Wed, 23 Jul 2014 12:17:57 -0000
Message-ID: <20140723121757.4203.58831@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Santhosh Edukulla" <noreply@reviews.apache.org>
References: <20140723120538.4203.13757@reviews.apache.org>
In-Reply-To: <20140723120538.4203.13757@reviews.apache.org>
Reply-To: "Santhosh Edukulla" <santhosh.edukulla@citrix.com>

--===============8396825898340988352==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On July 23, 2014, 12:05 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/marvinInit.py, line 114
> > <https://reviews.apache.org/r/23847/diff/1/?file=640532#file640532line114>
> >
> >     please use is not None, rather !=
> 
> Miguel Ferreira wrote:
>     I will do this this time, but if something is broken, I fix it and you see better ways of fixing it, please be my guest and do it yourself. after all that is the spirit of open-source, right?

sure, but lets make the submitter realize some better ways if there are, after all it helps the review submission and cleaner approach Agree? The review iam doing signifies its open source for your submission. Functionally, modifying your review submission is like altering the behavior and may add bugs, also resubmitting my review again.  


- Santhosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23847/#review48496
-----------------------------------------------------------


On July 23, 2014, 12:10 p.m., Miguel Ferreira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23847/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 12:10 p.m.)
> 
> 
> Review request for cloudstack, daan Hoogland, Santhosh Edukulla, and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Running a marvin test that does not specify a zone in the config file will produce an exception while parsing the config:
> 
> Exception Occurred Under init ['Traceback (most recent call last):\n', '  File "/usr/local/lib/python2.7/site-packages/marvin/marvinInit.py", line 118, in __setHypervisorAndZoneInfo\n    for zone in self.__parsedConfig.zones:\n', "TypeError: 'NoneType' object is not iterable\n"]
> 
> This happens when the code starts iterating over a list of zones that does not exist.
> I've added a check for the existence of the list of zones before iterating.
> 
> 
> Diffs
> -----
> 
>   tools/marvin/marvin/marvinInit.py ce9b43f 
> 
> Diff: https://reviews.apache.org/r/23847/diff/
> 
> 
> Testing
> -------
> 
> Tests now run without the mentioned exception
> 
> 
> Thanks,
> 
> Miguel Ferreira
> 
>


--===============8396825898340988352==--