Return-Path: X-Original-To: apmail-cloudstack-dev-archive@www.apache.org Delivered-To: apmail-cloudstack-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D115211F86 for ; Tue, 22 Jul 2014 18:15:15 +0000 (UTC) Received: (qmail 99732 invoked by uid 500); 22 Jul 2014 18:15:15 -0000 Delivered-To: apmail-cloudstack-dev-archive@cloudstack.apache.org Received: (qmail 99689 invoked by uid 500); 22 Jul 2014 18:15:15 -0000 Mailing-List: contact dev-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list dev@cloudstack.apache.org Received: (qmail 99641 invoked by uid 99); 22 Jul 2014 18:15:15 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Jul 2014 18:15:15 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 75ABC1DB906; Tue, 22 Jul 2014 18:15:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5808396853150115831==" MIME-Version: 1.0 Subject: Re: Review Request 23793: CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py From: "ASF Subversion and Git Services" To: "Girish Shilamkar" Cc: "Ashutosh Kelkar" , "ASF Subversion and Git Services" , "cloudstack" Date: Tue, 22 Jul 2014 18:15:02 -0000 Message-ID: <20140722181502.4203.96251@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "ASF Subversion and Git Services" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/23793/ X-Sender: "ASF Subversion and Git Services" References: <20140722070517.4204.93568@reviews.apache.org> In-Reply-To: <20140722070517.4204.93568@reviews.apache.org> Reply-To: "ASF Subversion and Git Services" X-ReviewRequest-Repository: cloudstack-git --===============5808396853150115831== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23793/#review48385 ----------------------------------------------------------- Commit 45888e214c949d1e48d800339b366c42a7990641 in cloudstack's branch refs/heads/master from Ashutosh K [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=45888e2 ] CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py - ASF Subversion and Git Services On July 22, 2014, 7:05 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23793/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 7:05 a.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Bugs: CLOUDSTACK-7137 > https://issues.apache.org/jira/browse/CLOUDSTACK-7137 > > > Repository: cloudstack-git > > > Description > ------- > > Resolved the cleanup issue. The security group was not removed from cleanup list after deleting it. So it failed to find the security group in cleanup operation. > > Also, removed the unnecessary imports. > > > Diffs > ----- > > test/integration/component/test_escalations_securitygroups.py 8934088 > > Diff: https://reviews.apache.org/r/23793/diff/ > > > Testing > ------- > > Yes. > Log: > @Desc: Test to List Security Groups pagination ... === TestName: test_01_list_securitygroups_pagination | Status : SUCCESS === > ok > @Desc: Test to Authorize and Revoke Ingress for Security Group ... SKIP: skip > @Desc: Test to Authorize and Revoke Egress for Security Group ... SKIP: skip > > ---------------------------------------------------------------------- > Ran 3 tests in 5.845s > > OK (SKIP=2) > > > Thanks, > > Ashutosh Kelkar > > --===============5808396853150115831==--