cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daan Hoogland <daan.hoogl...@gmail.com>
Subject Re: CLOUDSTACK-6242 - the fix needs to be reverted temporarily
Date Wed, 02 Jul 2014 20:46:18 GMT
On Wed, Jul 2, 2014 at 10:29 PM, Alena Prokharchyk
<Alena.Prokharchyk@citrix.com> wrote:
> c031eb7d38200d680da85ef57367b21df3483c41


So please amend and not revert? I suppose you are talking about
@@ -508,8 +512,9 @@ public class ConfigurationServerImpl extends
ManagerBase implements Configuratio
                         PreparedStatement stmt =
txn.prepareAutoCloseStatement(checkSql);
                         stmt.executeQuery();
                         tableName = "network_group";
-                    } catch (Exception ex) {
+                    } catch (SQLException ex) {
                         // if network_groups table exists, create the
default security group there
+                        s_logger.debug("Caught SQLException: no
network_group  ", ex);
                     }

                     insertSql = "SELECT * FROM " + tableName + "
where account_id=2 and name='default'";

Let's catch and log a generic exception. This is independent of
changing the script. All those other changes are improvements and in
fact this one is as well, no one would have looked at this hidden
feature of the dev env without it. Ignoring exceptions is bad practice
precisely for this reason.

-- 
Daan

Mime
View raw message