cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Wido den Hollander <w...@widodh.nl>
Subject Re: [CLOUDSTACK-6181] RBD Support not implemented
Date Tue, 22 Jul 2014 20:30:39 GMT


On 07/22/2014 10:13 PM, Logan Barfield wrote:
> Wido,
>
> I appreciate the confirmation.  Would you mind posting an update here when
> you've submitted the patch?  As I mentioned in another post we will
> probably end up just having to go into production with a non-official
> build.  We won't be able to wait for 4.5 or 4.4.x unfortunately.
>

I just pushed a patch: 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=173909e99d85cfcc85b017bc426950f9f16fddf0

That should also apply on 4.4 very easily, a simple cherry-pick should 
be sufficient.

Wido

>
> Thank You,
>
> Logan Barfield
> Tranquil Hosting
>
>
> On Tue, Jul 22, 2014 at 4:09 PM, Wido den Hollander <wido@widodh.nl> wrote:
>
>>
>>
>> On 07/22/2014 09:53 PM, Logan Barfield wrote:
>>
>>> I was testing on a recent 4.4 build today and noticed that volume resizing
>>> for RBD volumes is not working as intended.
>>>
>>> In LibvirtComputingResource.java the 'getResizeScriptType()' function
>>> doesn't have logic for type = RBD and format = RAW or QCOW2, so it returns
>>> 'null' and the resize operation fails.
>>>
>>> In CLOUDSTACK-6181 there was some discussion regarding RBD support, and it
>>> was signed off on by Wido (who appears to be the only contributor actively
>>> supporting Ceph in CloudStack).  Was the mentioned functionality just
>>> never
>>> implemented, or am I overlooking something?
>>>
>>>
>> So it seems you are right. I can't remember anymore why I signed it off
>> (probably because it worked locally), but what you are saying is true.
>>
>> RBD are block devices which do not exist in kernel space, so a script can
>> never check if the volume exists.
>>
>> The fix is rather simple, since libvirt can resize the volume it's just a
>> matter of a few if-statements in LibvirtComputing resouce, I'll get right
>> to that, but it will never make it into 4.4. Hopefully 4.4.1
>>
>> Wido
>>
>>
>>
>>>
>>> Thank You,
>>>
>>> Logan Barfield
>>> Tranquil Hosting
>>>
>>>
>

Mime
View raw message