cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Aradhye" <gaurav.arad...@clogeny.com>
Subject Review Request 24154: CLOUDSTACK-7215: Make expunge=True as default parameter value while calling destroyVirtualMachine through base library
Date Thu, 31 Jul 2014 14:58:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24154/
-----------------------------------------------------------

Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-7215
    https://issues.apache.org/jira/browse/CLOUDSTACK-7215


Repository: cloudstack-git


Description
-------

In almost 90% of the scenarios where VMs are created through test case, VMs are added to cleanup
list and the delete method is called for them through cleanup_resources method in utils.py
file.

These VMs remain in destroyed state for long time and keep blocking the resources (IP Address
etc) and hence the load on the setup on which regression build is fired increases.

Making expunge=True as default parameter in destroyVirtualMachine api call through base library
will make all these VMs expunge quickly making resources available for next test cases.

Also, it can be passed as False whenever we don't want VM to expunge immediately, and in case
when we recover the VM through test case after destroying it. Pass expunge=False for all such
scenarios.

This will hugely boost the test cases execution speed too.


Diffs
-----

  test/integration/component/test_advancedsg_networks.py 2794f96 
  test/integration/component/test_multiple_ips_per_nic.py 24b85df 
  test/integration/component/test_ps_domain_limits.py afb0955 
  test/integration/component/test_ps_limits.py 1993e93 
  test/integration/component/test_vpc_vm_life_cycle.py fd995cd 
  tools/marvin/marvin/lib/base.py 58033c6 

Diff: https://reviews.apache.org/r/24154/diff/


Testing
-------

Yes.


Thanks,

Gaurav Aradhye


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message