cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Santhosh Edukulla" <santhosh.eduku...@citrix.com>
Subject Re: Review Request 24111: Coverity findings for brocade-plugin
Date Thu, 31 Jul 2014 07:01:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24111/#review49213
-----------------------------------------------------------



plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
<https://reviews.apache.org/r/24111/#comment86092>

    This particular try\except  is  for an IO exception possible when closing a resource,
so the message should have some reflection in it. But, when you use try-with-resource as mentioned
in other issue, this is not required.


- Santhosh Edukulla


On July 30, 2014, 7:44 p.m., Ritu  Sabharwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24111/
> -----------------------------------------------------------
> 
> (Updated July 30, 2014, 7:44 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-6823
>     https://issues.apache.org/jira/browse/CLOUDSTACK-6823
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixed Coverity findings for brocade-plugin
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/brocade-vcs/src/com/cloud/api/response/BrocadeVcsDeviceResponse.java
60edbcf 
>   plugins/network-elements/brocade-vcs/src/com/cloud/network/brocade/BrocadeVcsApi.java
d5f06f8 
> 
> Diff: https://reviews.apache.org/r/24111/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ritu  Sabharwal
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message