cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Brett" <alex.br...@citrix.com>
Subject Review Request 24050: CLOUDSTACK-7173 Make getNewMinIops and getNewMaxIops return Longs
Date Tue, 29 Jul 2014 12:56:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24050/
-----------------------------------------------------------

Review request for cloudstack.


Bugs: CLOUDSTACK-7173
    https://issues.apache.org/jira/browse/CLOUDSTACK-7173


Repository: cloudstack-git


Description
-------

The functions getNewMinIops and getNewMaxIops were returning long primitives, this can throw
a NPE as the underlying Long objects could be null, which was causing volume resizes to fail.

The only place this getter is called is expecting a Long object, so changing it to return
a Long rather than long should be safe.


Diffs
-----

  server/src/com/cloud/storage/VmWorkResizeVolume.java 1caab10 

Diff: https://reviews.apache.org/r/24050/diff/


Testing
-------

Verified cloudstack still builds


Thanks,

Alex Brett


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message