cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damodar Reddy Talakanti" <damoder.re...@citrix.com>
Subject Re: Review Request 23915: Fixing some coverity reported issues
Date Fri, 25 Jul 2014 08:55:47 GMT


> On July 25, 2014, 7:05 a.m., daan Hoogland wrote:
> > Looks ok, did you verify whether the called functions at all return null? If they
don't this would seem a false positive. Your change wouldn't hurt anyhow.

I checked the xen code base they are returning null values as well.


- Damodar Reddy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23915/#review48713
-----------------------------------------------------------


On July 25, 2014, 6:10 a.m., Damodar Reddy Talakanti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23915/
> -----------------------------------------------------------
> 
> (Updated July 25, 2014, 6:10 a.m.)
> 
> 
> Review request for cloudstack, Rajani Karuturi and Santhosh Kumar.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Fixing some coverity reported issues in CitrixResourceBase.java
> 
> 
> Diffs
> -----
> 
>   plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
71aa01e 
> 
> Diff: https://reviews.apache.org/r/23915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Damodar Reddy Talakanti
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message