cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF Subversion and Git Services" <asf...@urd.zones.apache.org>
Subject Re: Review Request 23879: CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region through test case
Date Thu, 24 Jul 2014 14:50:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23879/#review48654
-----------------------------------------------------------


Commit 59c77fbaa4c07e2de9578369e69f47d0e71039b8 in cloudstack's branch refs/heads/master from
Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=59c77fb ]

CLOUDSTACK-7127: Fix for addRegion failure, avoiding regionid 1 while creating new region
through test case


- ASF Subversion and Git Services


On July 24, 2014, 2:44 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23879/
> -----------------------------------------------------------
> 
> (Updated July 24, 2014, 2:44 p.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7127
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7127
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> We are choosing random region id while passing it to addRegion test case. The test case
failed when region id 1 was passed because the region id was already in use.
> It is better to start the range from 2, as 1 will most likely be used in existing setup.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_regions.py 7b7c4a4 
> 
> Diff: https://reviews.apache.org/r/23879/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> Log:
> Test for duplicate checks on region id ... === TestName: test_createRegionWithExistingRegionId
| Status : SUCCESS ===
> ok
> Test for duplicate checks on region name ... === TestName: test_createRegionWithExistingRegionName
| Status : SUCCESS ===
> ok
> Test for update Region ... === TestName: test_updateRegion | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 3 tests in 2.845s
> 
> OK
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message